Issue 1462 related fixes #1155
Merged
Issue 1462 related fixes #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the drop table logic so it occurs only once. Adds line comment filtering since a few line comments followed by an `ALTER TABLE` statement could be excluded using simpler skip logic for empty queries. Improved the show details output as well as it runs through any additional queries that may be present in the `-schema.sql` files, although in the majority of cases the files should only contain the single `CREATE TABLE` query.
These extra tests should help to avoid a regression for what issue 1462 reported.
doncovski
approved these changes
Nov 28, 2025
doncovski
left a comment
doncovski
left a comment
There was a problem hiding this comment.
Ran tests with local build and it passed properly as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to address an issue that was reported where if a
-schema.sqlfile contains extra SQL comments at the end after theCREATE TABLEquery the table would get dropped right after creation if using the--overwrite-tablesflag.This adjusts the logic so the
DROP TABLEonly occurs once, and should also allow for the-schema.sqlfile to ignore SQL comment lines.The changes should also allow for extra
ALTER TABLEqueries, if present, to be processed successfully.Separately, some related tests have been added in to go with the changes.